Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(@angular-devkit/build-angular): use incremental bundling for component styles in esbuild builders #25965

Merged

Conversation

clydin
Copy link
Member

@clydin clydin commented Oct 5, 2023

When using the esbuild-based builders (esbuild-browser/application) in watch mode (including ng serve), component stylesheets will now be incrementally rebuilt when needed. This avoids a full build of each affected component's styles during an application rebuild. Both JIT and AOT mode are supported as well as both inline and external styles.

@clydin clydin added the target: major This PR is targeted for the next major release label Oct 5, 2023
@clydin clydin marked this pull request as draft October 5, 2023 17:03
@clydin clydin force-pushed the esbuild/incremental-component-styles branch 2 times, most recently from 8c997ae to 9ce1818 Compare October 5, 2023 17:34
…ponent styles in esbuild builders

When using the esbuild-based builders (`esbuild-browser`/`application`) in watch mode (including `ng serve`),
component stylesheets will now be incrementally rebuilt when needed. This avoids a full build of each
affected component's styles during an application rebuild. Both JIT and AOT mode are supported as well
as both inline and external styles.
@clydin clydin force-pushed the esbuild/incremental-component-styles branch from 9ce1818 to 079ee80 Compare October 5, 2023 18:58
@clydin clydin marked this pull request as ready for review October 5, 2023 19:25
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 5, 2023
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 9, 2023
@alan-agius4 alan-agius4 removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 9, 2023
@alan-agius4 alan-agius4 merged commit 223a82f into angular:main Oct 9, 2023
35 checks passed
@clydin clydin deleted the esbuild/incremental-component-styles branch October 9, 2023 14:18
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants